Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14832 Mention anything as password during cluster up #14861

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix #14832 Mention anything as password during cluster up #14861

merged 1 commit into from
Jun 30, 2017

Conversation

coolbrg
Copy link
Contributor

@coolbrg coolbrg commented Jun 23, 2017

Fix #14832

Also formatted comments.

Output will look like as:

$ _output/local/bin/linux/amd64/oc cluster up
Starting OpenShift using openshift/origin:v3.6.0-alpha.2 ...
Pulling image openshift/origin:v3.6.0-alpha.2
Pulled 0/4 layers, 2% complete
Pulled 1/4 layers, 39% complete
Pulled 2/4 layers, 56% complete
Pulled 3/4 layers, 97% complete
Pulled 4/4 layers, 100% complete
Extracting
Image pull complete
OpenShift server started.

The server is accessible via web console at:
    https://127.0.0.1:8443

You are logged in as:
    User:     developer
    Password: <anything> (unauthenticated)

To login as administrator:
    oc login -u system:admin

Let me know if any changes needed.

@csrwng
Copy link
Contributor

csrwng commented Jun 26, 2017

@budhrg thinking about it some more, the (unauthenticated) part may be misleading, since you are authenticated as that user. Also instead of <anything>, I think <any password> may sound better. @bparees thoughts?

@bparees
Copy link
Contributor

bparees commented Jun 26, 2017

@csrwng how about: Password: <any value> ?

agree on the concern about unauthenticated.

@csrwng
Copy link
Contributor

csrwng commented Jun 26, 2017

I like <any value> :)

@coolbrg
Copy link
Contributor Author

coolbrg commented Jun 26, 2017

Updated the PR @csrwng :)

@csrwng
Copy link
Contributor

csrwng commented Jun 26, 2017

LGTM
[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@deads2k
Copy link
Contributor

deads2k commented Jun 26, 2017

re[test]

@csrwng
Copy link
Contributor

csrwng commented Jun 26, 2017

Flake #14129
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to de74ee7

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2652/) (Base Commit: 3c328f7) (PR Branch Commit: de74ee7)

@bparees
Copy link
Contributor

bparees commented Jun 27, 2017

@budhrg you need to gofmt the file.

./pkg/bootstrap/docker/up.go
!!! gofmt needs to be run on the following files: 
Try running 'gofmt -s -d [path]'

@coolbrg
Copy link
Contributor Author

coolbrg commented Jun 28, 2017

Done @bparees . Thanks 😄

@bparees
Copy link
Contributor

bparees commented Jun 28, 2017

[merge]

@bparees
Copy link
Contributor

bparees commented Jun 29, 2017 via email

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017

[merge]

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017 via email

@bparees
Copy link
Contributor

bparees commented Jun 30, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4ad5496

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 30, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1188/) (Base Commit: 57a4d50) (PR Branch Commit: 4ad5496) (Image: devenv-rhel7_6415)

@openshift-bot
Copy link
Contributor

Origin Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested

@openshift-bot openshift-bot merged commit 7004e83 into openshift:master Jun 30, 2017
@coolbrg coolbrg deleted the fix-14832 branch July 2, 2017 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@csrwng csrwng

Labels
priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coolbrg @csrwng @bparees @openshift-bot @deads2k @pweil-